Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Update Processes tooltips #166251

Merged
merged 2 commits into from
Sep 13, 2023
Merged

[Infra UI] Update Processes tooltips #166251

merged 2 commits into from
Sep 13, 2023

Conversation

jennypavlova
Copy link
Member

@jennypavlova jennypavlova commented Sep 12, 2023 •
edited
Loading

Closes #165822

Summary

This PR moves the explanation tooltip to the top processes title and changes the explanation text:

image

Testing

  1. Go to hosts view, open the hosts flyout and go to the processes tab - the new tooltip should be visible (using the Top processes icon to open it)
  2. Go to the asset details page and do the same steps:
top_processes_popup.mov

@jennypavlova jennypavlova added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Sep 12, 2023
@jennypavlova jennypavlova self-assigned this Sep 12, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jennypavlova jennypavlova marked this pull request as ready for review September 12, 2023 13:56
@jennypavlova jennypavlova requested a review from a team as a code owner September 12, 2023 13:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

mykolaharmash
mykolaharmash approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good ✨ Left a few comments for the code but they are totally non-blocking.

x-pack/plugins/infra/public/components/asset_details/components/top_processes_tooltip.tsx Outdated
'https://www.elastic.co/guide/en/observability/current/view-infrastructure-metrics.html';
const SYSTEM_INTEGRATION_DOCS_LINK = 'https://docs.elastic.co/en/integrations/system';

export const TopProcessesTooltipContent = React.memo(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to name the file and component inside using the same name, but I'm not sure how strictly we follow this convention usually

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After moving the popup here I renamed it to TopProcessesTooltip which matches the file name

x-pack/plugins/infra/public/components/asset_details/components/top_processes_tooltip.tsx Outdated

export const TopProcessesTooltipContent = React.memo(() => {
const onClick = (e: React.MouseEvent<HTMLDivElement, MouseEvent>) => {
e.stopPropagation();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify please why this is needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added initially as a bug fix because of the table sorting issue with the tooltip there #161565 but in this case, I don't think we need it - removed 👍

x-pack/plugins/infra/public/components/asset_details/tabs/processes/processes.tsx Outdated
@@ -119,23 +120,19 @@ export const Processes = () => {
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiIconTip
<Popover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it makes sense to put the whole popover into the dedicated component instead of just its content. it would declutter a bit the parent component, and strictly speaking, there is no need to have the content separately as we don't use it anywhere else. wdyt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes in this case it makes sense to keep the Popover inside the other component as the content is not used anywhere else 👍 Changed

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts / alerting api integration security and spaces enabled - Group 2 Connectors ServiceNow ITSM ServiceNow ITSM - Action Creation should set the usesTableApi to true when not provided

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1444 1445 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB -391.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

@mykolaharmash
Copy link
Contributor

Thank you for addressing the comments 🙌

@jennypavlova jennypavlova merged commit 21d3fc4 into elastic:main Sep 13, 2023
@jennypavlova jennypavlova deleted the 165822-infra-ui-update-processes-tooltips branch September 13, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykolaharmash mykolaharmash mykolaharmash approved these changes

Assignees

@jennypavlova jennypavlova

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra UI] Update Processes tooltips
6 participants
@jennypavlova @apmmachine @elasticmachine @kibana-ci @mykolaharmash @kibanamachine